Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for macro paths and call chain parsing #144

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

c42f
Copy link
Member

@c42f c42f commented Nov 3, 2022

Correctly parse dots and other same-precedence chaining after macro calls:

@A().x
@A{a}.x
@A[a].x

Also allow general forms in macro paths, such as calls:

f().@x

This is allowed by the reference parser but seemed weird so it was disallowed here. But it turns out this doesn't prevent computed macro paths as the A in A.@x is looked up dynamically - so just simplify things and allow this.

Fixes two parts of #134

Correctly parse dots and other same-precedence chaining after macro
calls:

    @A().x
    @A{a}.x
    @A[a].x

Also allow general forms in macro paths, such as calls:

    f().@x

This is allowed by the reference parser but seemed weird so it was
disallowed here. But it turns out this doesn't prevent computed macro
paths as the A in A.@x is looked up dynamically - so just simplify
things and allow this.
@c42f c42f merged commit eb3259f into main Nov 3, 2022
@c42f c42f deleted the c42f/fix-macro-paths-and-call-chains branch November 3, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant